Improve orDominator #12272
Merged
Improve orDominator #12272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge applied type arguments also for abstract and opaque type constructors Fixes scala#12264
smarter
reviewed
Apr 29, 2021
| @@ -343,7 +343,12 @@ object TypeOps: | |||
|
|
|||
| tp match { | |||
| case tp: OrType => | |||
| approximateOr(tp.tp1, tp.tp2) | |||
| (tp.tp1.dealias, tp.tp2.dealias) match | |||
| case (tp1 @ AppliedType(tycon1, args1), tp2 @ AppliedType(tycon2, args2)) | |||
There was a problem hiding this comment.
While this addresses the most common issue, I don't think that's enough to handle things like Tag[Long] | (Tag[Int] & SomeTrait) or type Tag2[X] <: Tag[X]; Tag[Long] | Tag2[Int]. But to properly deal with all possible cases it seems that we'd need a generalization of baseClasses that also returns base abstract types.
There was a problem hiding this comment.
Since what we do here is an approximation anyway, I'd leave that under possible future improvement.
smarter
approved these changes
Apr 29, 2021
| @@ -343,7 +343,12 @@ object TypeOps: | |||
|
|
|||
| tp match { | |||
| case tp: OrType => | |||
| approximateOr(tp.tp1, tp.tp2) | |||
| (tp.tp1.dealias, tp.tp2.dealias) match | |||
| case (tp1 @ AppliedType(tycon1, args1), tp2 @ AppliedType(tycon2, args2)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge applied type arguments also for abstract and opaque type constructors
Fixes #12264